download_url: set check_error=False on HEAD request - #943
Merged
Merged
Conversation
soxofaan
reviewed
Sep 23, 2026
pjonsson
force-pushed
the
head-accept-403
branch
from
September 23, 2026 17:56
45a59f3 to
d0c22c7
Compare
pjonsson
changed the title
pjonsson
force-pushed
the
head-accept-403
branch
from
September 23, 2026 18:06
d0c22c7 to
87ab6b5
Compare
pjonsson
changed the title
soxofaan
reviewed
Sep 24, 2026
Running HEAD on a pre-signed S3 URI gives a 403 response because the URI is signed for GET, so accept a failure for the HEAD request and let the download deal with the issue. Fixes Open-EO#939
pjonsson
force-pushed
the
head-accept-403
branch
from
September 24, 2026 09:55
87ab6b5 to
5fd30e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running HEAD on a pre-signed S3 URI
gives a 403 response because the URI
is signed for GET, so accept a failure
for the HEAD request and let
the download deal with the issue.
Fixes #939